Rename "development environment" to "development container" #910
Conversation
Codecov Report
@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 33.37% 33.41% +0.03%
==========================================
Files 67 67
Lines 5378 5378
==========================================
+ Hits 1795 1797 +2
+ Misses 3434 3432 -2
Partials 149 149
Continue to review full report at Codecov.
|
cmd/restart.go
Outdated
| @@ -31,7 +31,7 @@ func Restart() *cobra.Command { | |||
|
|
|||
| cmd := &cobra.Command{ | |||
| Use: "restart", | |||
| Short: "Restarts the pods of your development environment", | |||
| Short: "Restarts the services of your okteto manifest", | |||
There was a problem hiding this comment.
This is the only one that sounds odd. The rest of the changes are much more clear now.
What about Restarts the pods containing your development container? or Restart the pod of your development container or something like that... I'm not sure if my proposal is accurate enough.
There was a problem hiding this comment.
This command restarts the pods indicated by the services field of the okteto manifest. It does not restart the dev container. What about something like:
Restarts the pods references by the "services" field of the okteto manifest
There was a problem hiding this comment.
Sounds more accurate like that then
There was a problem hiding this comment.
In kubernetes you don't restart services, you recreate (or restart) the pods. I think we should use more kubernetes-specific in this kind of descriptions.
There was a problem hiding this comment.
Maybe: restarts the deployment listed in the services field of the okteto manifest?
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com
Proposed changes