Return clean on failure #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
==========================================
- Coverage 34.68% 34.64% -0.04%
==========================================
Files 67 67
Lines 5648 5654 +6
==========================================
Hits 1959 1959
- Misses 3535 3540 +5
- Partials 154 155 +1
Continue to review full report at Codecov.
|
rberrelleza
commented
Jun 15, 2020
| @@ -806,6 +806,8 @@ func (up *UpContext) cleanCommand() { | |||
|
|
|||
| if err != nil { | |||
| log.Infof("failed to clean session: %s", err) | |||
| up.cleaned <- struct{}{} | |||
There was a problem hiding this comment.
@pchico83 do you think we should fail the sequence here instead?
pchico83
approved these changes
Jun 16, 2020
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the "clean" command fails, we shouldn't try and get the watches configuration from the remote container.