Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print watches warning after the clean command finishes #936

Merged
merged 2 commits into from Jun 18, 2020

Conversation

rberrelleza
Copy link
Member

@rberrelleza rberrelleza commented Jun 18, 2020

This is to avoid writing while the spinner is still printing out (it messes up the output)

image

Signed-off-by: Ramiro Berrelleza rberrelleza@gmail.com

…ides

Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Ramiro Berrelleza <rberrelleza@gmail.com>
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #936 into master will increase coverage by 0.00%.
The diff coverage is 10.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files          67       67           
  Lines        5655     5654    -1     
=======================================
  Hits         1959     1959           
+ Misses       3541     3540    -1     
  Partials      155      155           
Impacted Files Coverage Δ
cmd/up.go 6.29% <0.00%> (+0.01%) ⬆️
pkg/k8s/pods/pod.go 12.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644dad2...5812ce5. Read the comment docs.

@rberrelleza rberrelleza merged commit f1dc839 into master Jun 18, 2020
@rberrelleza rberrelleza deleted the print-watches-after branch June 18, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant