Check storageclass for generating okteto manifests #956
Conversation
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 34.60% 34.43% -0.17%
==========================================
Files 69 69
Lines 5759 5787 +28
==========================================
Hits 1993 1993
- Misses 3610 3638 +28
Partials 156 156
Continue to review full report at Codecov.
|
cmd/init/init.go
Outdated
| return false | ||
| } | ||
|
|
||
| return len(stClassList.Items) > 0 |
There was a problem hiding this comment.
we should also check that there's a default storage class, I think some of the issues come from there.
Also, what about incompatible storage classes? (e.g. the issue we saw with minikube and the volumes not persisting a restart). Maybe we can identify those by name and log a warning?
| @@ -122,6 +124,11 @@ func Run(namespace, devPath, language, workDir string, overwrite bool) error { | |||
| log.Yellow(fmt.Sprintf("Analysis for deployment '%s' failed: %s", d.Name, err)) | |||
| } | |||
| } | |||
|
|
|||
| if !supportsPersistentVolumes(namespace) { | |||
There was a problem hiding this comment.
should we log warnings when there are errors?
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Co-authored-by: Ramiro Berrelleza <rberrelleza@gmail.com>
Signed-off-by: Pablo Chico de Guzman <pchico83@gmail.com>
Signed-off-by: Pablo Chico de Guzman pchico83@gmail.com
Fixes #947