Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gas pricer default price and dynamic price calculation pipeline #61

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Fix gas pricer default price and dynamic price calculation pipeline #61

merged 6 commits into from
Jul 15, 2024

Conversation

sieniven
Copy link

@sieniven sieniven commented Jul 10, 2024 •
edited

Summary

This PR fixes issues on the L2 gaspricer pipeline:

  • If default price is not configured, oracle will automatically set default price to minimum base fee (10 gwei)
  • Likewise on X Layer gpcache initialization, if default price is not configured, cache will automatically set default price to DefaultXLayerPrice (1 gwei)
  • Better refactor lastPrice to defaultPrice on the oracle. lastPrice is never used in any pipeline now and we cannot assume that upstream will not change or use it. Since we want the dynamic GP checks on the dynamic price calculated to be checked against the default price, we should do this instead
  • Fix default gas price config to only be zkevm.default-gas-price

@sieniven sieniven mentioned this pull request Jul 10, 2024
Merged
@KamiD KamiD merged commit 73abff8 into dev Jul 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjg555543 zjg555543 zjg555543 approved these changes

@LeoGuo621 LeoGuo621 LeoGuo621 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sieniven @zjg555543 @LeoGuo621 @KamiD