fix encodeHTMLSource when code = 0 #178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when encodeHTMLSource got a parameter code = 0, encodeHTMLSource will output '' , but the expected output is '0'
|
I have same issue on this. But it shouldn't just be compared with Related PR: #183 |
|
feel free to reopen #191 due to maintain issues with this fork |
|
@hustxiaoc please see #183 (comment) Either of the PRs can be merged after those changes, let me know if you would like to do it. |
sgruetter
added a commit
to sgruetter/doT
that referenced
this pull request
Dec 17, 2018
This change fixes an issue where falsy values (i.e. false, null,
undefined, 0, NaN) lead to an empty string. All of these values except
undefined are now stringified when rendering with {{! }} to have them
rendered. undefined continues to lead to an empty string to avoid
introduce many issues with existing usages.
Fixes olado#274, olado#170, olado#178, olado#183.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when encodeHTMLSource got a parameter code = 0, encodeHTMLSource will output '' , but the expected output is
'0'