Fix {{!value}} out when the value is number 0 #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epoberezkin I think templet engine does not expects the input value is always string, just like jsp, <%=new Integer(0) %> it will out "0" not "" , and {{=does the right output ,it will be '0', {{! should be the same, and also there're similar issues before, like #170 , #178, #183 . The tests failed last time because the travis itself, anyway I send a new PR in v2.0.0. |
sgruetter
added a commit
to sgruetter/doT
that referenced
this pull request
Dec 17, 2018
This change fixes an issue where falsy values (i.e. false, null,
undefined, 0, NaN) lead to an empty string. All of these values except
undefined are now stringified when rendering with {{! }} to have them
rendered. undefined continues to lead to an empty string to avoid
introduce many issues with existing usages.
Fixes olado#274, olado#170, olado#178, olado#183.
|
2.0 will support custom encoders, non-strings will be interpolated as is. |
This was referenced Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{!value}} out '' when the value is number 0 or boolean false, but{{=value}} is right, so I think this should be fixed.