Replace fixed class method calls with self(.class) in Unit class #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces every class method call `RubyUnits::Unit.method` with either `method` (in class methods) or `self.class.method` (in instance methods). This allows us to override a class method in a sub class and make sure that every call to that method from it's instances use the new definition. E.g. we can have a sub class which extends from RubyUnits::Unit and override eliminate_terms which is then used when dividing or multiplicating instances of this sub class.
olbrich
added
feature request
Minor
olbrich
approved these changes
Nov 21, 2021
|
@kreintjes If you update this with master, I'll merge it in. |
|
Thanks for the review!
Do you prefer a rebase or merge commit? If a merge commit is fine, then I'll press this button:
Otherwise it will have to wait a bit longer. |
|
@kreintjes a merge commit is fine, I'm going to squash the branch anyway when I merge it. Go ahead and press the button. |
I was now in the position to do either (but actually kind of forgot about this :p), but pressing the button is much easier anyway, so done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces every class method call
RubyUnits::Unit.methodwith eithermethod(in class methods) or
self.class.method(in instance methods).This allows us to override a class method in a sub class and make sure that
every call to that method from it's instances use the new definition.
E.g. we can have a sub class which extends from RubyUnits::Unit and override
eliminate_terms which is then used when dividing or multiplicating instances
of this sub class.