Guard performance.* with report_logs_in_timings
#4
Conversation
The global `performance` object is not available in some javascript enviroments. E.g.: - nodejs exports it as `perf_hooks.performance`, not as a global `peformance` object. - cloudflare workers have a limited subset of global objects which does not include `performance` at all. `WASMLayerConfig` allows opt-out of the performance timing APIs with the `report_logs_in_timings` option, but it was not previously being checked before some usage of `performance.mark` and `performance.measure`. This patch guards those calls against the config option.
|
Hi @jenanwise, for this use-case, I think there is a way to expand the configuration options to affect which binding for performance marks is used. So, this feels more like an additional "wasm_context" configuration value, that could be WDYT? |
|
@colelawrence I'm not sure I follow. This PR just uses the already-in-place boolean |
|
To expand: as an additional step, you could either dynamically fetch the right |
|
Sorry for coming back to this late so late, but I think the goal was to make it so you could disable little ticks in the performance spans API if you didn't want the logging duplication (between performance and console.log). I think we should rename the existing config name to We could also make WDYT? |
|
@colelawrence That sounds reasonable to me. I haven't thought about wasm in almost a year though, so I will defer to you at this point 😄 |
I'm not sure if you intend for this library to be used outside of browsers. See #3 for that question. If so, currently,
tracing-wasmdoesn't work in environments where the globalperformanceobject is not available. E.g.:nodejs exports it as
perf_hooks.performance, not as a globalpeformanceobject.cloudflare workers have a limited subset of global objects which does not include
performanceat all.WASMLayerConfigallows opt-out of the performance timing APIs with thereport_logs_in_timingsoption, but it was not previously being checked before some usage ofperformance.markandperformance.measure. This patch guards those calls against the config option.