Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard performance.* with report_logs_in_timings #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Aug 9, 2020

  1. Guard performance.* with report_logs_in_timings.

    The global `performance` object is not available in some javascript
    enviroments. E.g.:
    
    - nodejs exports it as `perf_hooks.performance`, not as a global
    `peformance` object.
    
    - cloudflare workers have a limited subset of global objects which does
    not include `performance` at all.
    
    `WASMLayerConfig` allows opt-out of the performance timing APIs with the
    `report_logs_in_timings` option, but it was not previously being checked
    before some usage of `performance.mark` and `performance.measure`. This
    patch guards those calls against the config option.
    jenanwise committed Aug 9, 2020
    Configuration menu
    Copy the full SHA
    a65ceed View commit details
    Browse the repository at this point in the history