Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue #9

Closed
brettz9 opened this issue Nov 15, 2019 · 1 comment
Closed

Security issue #9

brettz9 opened this issue Nov 15, 2019 · 1 comment

Comments

@brettz9
Copy link
Contributor

brettz9 commented Nov 15, 2019

Hi,

The code at https://github.com/oldj/node-font-list/blob/master/libs/win32/index.js#L69-L71 is being flagged by https://lgtm.com/projects/g/oldj/node-font-list/?mode=list with an explanation for the concern at https://lgtm.com/rules/1510773276307/ . It appears that this concern could be minimized by using:

let cmd = 'cscript'
execFile(cmd, [fn], (err, stdout, stderr) => {

Btw, I find LGTM.com to be a useful site which picks up issues like this which ESLint does not (and across multiple languages), and they have an integration for your site's PRs in case you might be interested: https://lgtm.com/help/lgtm/github-apps-integration

oldj added a commit that referenced this issue Nov 15, 2019
@oldj
Copy link
Owner

oldj commented Nov 15, 2019

Thanks!

@oldj oldj closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants