Add vilebotmoji #92
Merged
Add vilebotmoji #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +55,10 @@ private String kaomojiify(String message) throws Exception { | |||
| else if (words[0].equals("nsfw") | words[0].equals("wtf")){ | |||
There was a problem hiding this comment.
I think circuit-break or || is intended here instead of bitwise or |. Since both operands are booleans, the only different is that this might do an additional equals call that is not needed.
There was a problem hiding this comment.
You’re right, that change would be preferable. I might as well change it in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a specific kaomoji for vilebot: ( ͡° ͜ʖ ͡° )