Adds user selected language in <html lang=""> #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses the SITE_MAIN_LANGUAGE set in the .env for all lang attributes in html elements. This improves accessibility.
|
This looks good! I've also looked over the corresponding PR in the plugin repo, which also looks good. I'll release it right away. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be seen in connection with oleeskild/obsidian-digital-garden#473 and oleeskild/obsidian-digital-garden#472
This commit uses the SITE_MAIN_LANGUAGE set in the .env for all lang attributes in html elements. If no SITE_MAIN_LANGUAGE is set, it defaults to
<html lang="en">.This is part of my first pull request (and I have zero Obsidian plugin development experience), so please be very critical of my work.