Adds setting for site main language #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a setting for the site main language. This setting is used to set the the `lang` attribute of the html element. This improves accessibility and assists search engines and browsers. Reference: https://www.w3schools.com/tags/ref_language_codes.asp
oleeskild
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
This looks good! I'm gonna merge it in, do some testing, and if everything looks okay I'll make a new release. Thank you for the contribution! This could also be the first step in creating localization support, where all the hardcoded strings can be set based on what language you've chosen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #472
Adds a setting for the digital garden's main language which is saved to the user's .env.
This setting is used by the template (see new PR) to set the the
langattribute of the html element. This improves accessibility and assists search engines and browsers.Reference: https://www.w3schools.com/tags/ref_language_codes.asp
This is my first pull request (and I have zero Obsidian plugin development experience), so please be critical of my work.