Trigger a 'change' Event after setting a value. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewnicols
added a commit
to andrewnicols/moodle-behat-extension
that referenced
this pull request
Dec 22, 2020
To facilitate this we use the oleg-andreyev/MinkPhpWebDriver Mink Driver rather than any provided by the minkphp project, which have yet to add support for php-webdrier. The oleg-andreyev driver is largely complete, but there are a handful of bugs waiting to be merged. As a result, this branch currently follows my fork of the driver which is a branch with all of the pull requests applied. These pull requests are: - oleg-andreyev/MinkPhpWebDriver#8 Opening, closing, and re-opening a window with the same name attempts to reopen the closed window. - oleg-andreyev/MinkPhpWebDriver#10 Work around a bug in geckodriver whereby the pointer location is not updated when calling click() - oleg-andreyev/MinkPhpWebDriver#11 Trigger a synthetic `change` event rather than pressing TAB after sendKeys. - oleg-andreyev/MinkPhpWebDriver#12 Work around a bug in geckodriver where an ElementNotInteractable error is thrown when attempting to click on a link whose first child is a block-level element. This change moves away from the MoodleSeleium2 Driver and Factory in favour of the more generic WebDriver and WebDriverFactory. The changes here also remove the need for the modified syn.js library, which is no longer used in favour of a true synthetic event. The customistations in NodeElement are also no longer required as most of them have been addressed in the php-webdriver/webdriver project, or are worked around in the oleg-andreyev/MinkPhpWebDriver driver.
andrewnicols
added a commit
to andrewnicols/moodle-behat-extension
that referenced
this pull request
Dec 22, 2020
To facilitate this we use the oleg-andreyev/MinkPhpWebDriver Mink Driver rather than any provided by the minkphp project, which have yet to add support for php-webdrier. The oleg-andreyev driver is largely complete, but there are a handful of bugs waiting to be merged. As a result, this branch currently follows my fork of the driver which is a branch with all of the pull requests applied. These pull requests are: - oleg-andreyev/MinkPhpWebDriver#8 Opening, closing, and re-opening a window with the same name attempts to reopen the closed window. - oleg-andreyev/MinkPhpWebDriver#10 Work around a bug in geckodriver whereby the pointer location is not updated when calling click() - oleg-andreyev/MinkPhpWebDriver#11 Trigger a synthetic `change` event rather than pressing TAB after sendKeys. - oleg-andreyev/MinkPhpWebDriver#12 Work around a bug in geckodriver where an ElementNotInteractable error is thrown when attempting to click on a link whose first child is a block-level element. This change moves away from the MoodleSeleium2 Driver and Factory in favour of the more generic WebDriver and WebDriverFactory. The changes here also remove the need for the modified syn.js library, which is no longer used in favour of a true synthetic event. The customistations in NodeElement are also no longer required as most of them have been addressed in the php-webdriver/webdriver project, or are worked around in the oleg-andreyev/MinkPhpWebDriver driver.
andrewnicols
added a commit
to andrewnicols/moodle-behat-extension
that referenced
this pull request
Dec 22, 2020
To facilitate this we use the oleg-andreyev/MinkPhpWebDriver Mink Driver rather than any provided by the minkphp project, which have yet to add support for php-webdrier. The oleg-andreyev driver is largely complete, but there are a handful of bugs waiting to be merged. As a result, this branch currently follows my fork of the driver which is a branch with all of the pull requests applied. These pull requests are: - oleg-andreyev/MinkPhpWebDriver#8 Opening, closing, and re-opening a window with the same name attempts to reopen the closed window. - oleg-andreyev/MinkPhpWebDriver#10 Work around a bug in geckodriver whereby the pointer location is not updated when calling click() - oleg-andreyev/MinkPhpWebDriver#11 Trigger a synthetic `change` event rather than pressing TAB after sendKeys. - oleg-andreyev/MinkPhpWebDriver#12 Work around a bug in geckodriver where an ElementNotInteractable error is thrown when attempting to click on a link whose first child is a block-level element. This change moves away from the MoodleSeleium2 Driver and Factory in favour of the more generic WebDriver and WebDriverFactory. The changes here also remove the need for the modified syn.js library, which is no longer used in favour of a true synthetic event. The customistations in NodeElement are also no longer required as most of them have been addressed in the php-webdriver/webdriver project, or are worked around in the oleg-andreyev/MinkPhpWebDriver driver.
|
@andrewnicols please rebase on the master, I've switched to GitHub Actions. |
andrewnicols
force-pushed
the
setValueTab
branch
from
01777d8
to
32a13ed
Compare
oleg-andreyev
force-pushed
the
setValueTab
branch
from
32a13ed
to
8cc643d
Compare
|
@andrewnicols I've rebased your branch once again on master. |
andrewnicols
force-pushed
the
setValueTab
branch
from
8cc643d
to
9becb9a
Compare
|
@andrewnicols thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5.