Add a branch for Reedy on Mozilla Firefox #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove manifest settings not supported by Firefox - we need an add-on ID because we use storage.sync
Since Firefox doesn't support the fontSettings API yet, we use a hard coded list of web safe CSS fonts.
The msg.key property was accessed while not being set.
The variables are not needed, but the divs must still be created.
The rule ".e-Reedy-wrapper *" in content.css overrules the dynamically set styles, so we have to be more specific when setting our styles.
Unfortunately, we cannot use the HTML5 color picker in Firefox, because the popup immediately closes whenever the color picker opens. See https://bugzilla.mozilla.org/show_bug.cgi?id=1474423
The rule ".e-Reedy-wrapper *" in content.css overruled the dynamically set styles in case of the light theme. Now we use an explicit rule for the light theme as well.
Due to both security and performance concerns, the web-ext linter creates warnings when innerHTML() is used. This may also be problematic when submitting the add-on to Mozilla.
For some strange reason this is only needed in Firefox, not in Chrome.
|
@Cito Thank you very much for this work! |
|
@amal should I build version from firefox branch or use another plugin? |
|
I build the fork from the firefox branch and publish plugin. Enjoy! https://addons.mozilla.org/en-GB/firefox/addon/reedy-for-forefox/ ANd Huge thanks to @Cito for this port! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some of the things I needed to change in order to make it play well with Mozilla:
chrome-extension://should bemoz-extension://or simply use absolute pathI also did some code cleanup and modernization (e.g. using
letandconstinstead ofvar) that were not actually necessary for the code to run on Firefox.