Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a branch for Reedy on Mozilla Firefox #28

Merged
merged 19 commits into from Jul 13, 2018
Merged

Add a branch for Reedy on Mozilla Firefox #28

merged 19 commits into from Jul 13, 2018

Commits on Jul 9, 2018

  1. Adapt manifest.json for Firefox 

    - remove manifest settings not supported by Firefox
- we need an add-on ID because we use storage.sync
    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    ea8618b View commit details
    Browse the repository at this point in the history

  2. Ignore web-ext-artifacts

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    fb043be View commit details
    Browse the repository at this point in the history

  3. Adapt README for Firefox

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    23640f6 View commit details
    Browse the repository at this point in the history

  4. Grammar

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    42c424d View commit details
    Browse the repository at this point in the history

  5. Adapt chrome-extension-URLs for Firefox

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    993401d View commit details
    Browse the repository at this point in the history

  6. Use hardcoded list of fonts 

    Since Firefox doesn't support the fontSettings API yet,
we use a hard coded list of web safe CSS fonts.
    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    838b8d6 View commit details
    Browse the repository at this point in the history

  7. Fix some typos

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    b61de32 View commit details
    Browse the repository at this point in the history

  8. Remove Google Analytics

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    89666c8 View commit details
    Browse the repository at this point in the history

  9. Some code cleanup and modernization

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    cc350dc View commit details
    Browse the repository at this point in the history

  10. Adapt URL of system tabs to Firefox

    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    7915581 View commit details
    Browse the repository at this point in the history

  11. Fix problem with strict mode 

    The msg.key property was accessed while not being set.
    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    7452e15 View commit details
    Browse the repository at this point in the history

  12. Uncomment some erroneously commented lines again 

    The variables are not needed, but the divs must still be created.
    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    c273c69 View commit details
    Browse the repository at this point in the history

  13. Styles like font-family were not set 

    The rule ".e-Reedy-wrapper *" in content.css overrules
the dynamically set styles, so we have to be more specific
when setting our styles.
    @Cito
    Cito committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    40115d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. Use text input fields instead of HTML5 color picker 

    Unfortunately, we cannot use the HTML5 color picker in Firefox,
because the popup immediately closes whenever the color picker opens.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1474423
    @Cito
    Cito committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    80a0ce0 View commit details
    Browse the repository at this point in the history

  2. Proper patch for setting styles like font-family 

    The rule ".e-Reedy-wrapper *" in content.css overruled
the dynamically set styles in case of the light theme.
Now we use an explicit rule for the light theme as well.
    @Cito
    Cito committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    c3156ea View commit details
    Browse the repository at this point in the history

  3. Avoid using innerHTML() 

    Due to both security and performance concerns, the web-ext
linter creates warnings when innerHTML() is used. This may
also be problematic when submitting the add-on to Mozilla.
    @Cito
    Cito committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    8bd7d74 View commit details
    Browse the repository at this point in the history

  4. Add some bottom margin to help text 

    For some strange reason this is only needed in Firefox, not in Chrome.
    @Cito
    Cito committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    ff96eab View commit details
    Browse the repository at this point in the history

  5. Better handling of newlines in the context

    @Cito
    Cito committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    fd515db View commit details
    Browse the repository at this point in the history

  6. Adapt error message mentioning Google Chrome

    @Cito
    Cito committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    f1f9a76 View commit details
    Browse the repository at this point in the history