Merge pull request #23 from olegskl/fix-reporter-do-not-write-empty-l…

…ines-to-console fix(reporter): don't write empty report to console
olegskl · Apr 23, 2016 · a96afde · a96afde
2 parents 6c22e8b + ec355e2
commit a96afde
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/reporter-factory.js b/src/reporter-factory.js
@@ -46,7 +46,7 @@ export default function reporterFactory(config = {}, options = {}) {
      */
     const formattedText = formatter(results);
 
-    if (config.console) {
+    if (config.console && formattedText.trim()) {
       asyncTasks.push(
         gulpUtil.log(`\n${formattedText}\n`)
       );

diff --git a/test/reporter-factory.spec.js b/test/reporter-factory.spec.js
@@ -52,6 +52,21 @@ test('reporter should NOT write to console if console param is false', t => {
   gulpUtil.log.restore();
 });
 
+test('reporter should NOT write to console if formatter returned only whitespace', t => {
+  t.plan(1);
+  stub(gulpUtil, 'log');
+  const reporter = reporterFactory({
+    formatter() { return '  \n'; },
+    console: true
+  });
+  reporter({});
+  t.false(
+    gulpUtil.log.called,
+    'reporter has NOT written anything to console'
+  );
+  gulpUtil.log.restore();
+});
+
 test('reporter should NOT write to console by default', t => {
   t.plan(1);
   stub(gulpUtil, 'log');