Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting only/ignore matching on the host #38

Closed
RalfJung opened this issue Feb 6, 2023 · 3 comments · Fixed by #40
Closed

Supporting only/ignore matching on the host #38

RalfJung opened this issue Feb 6, 2023 · 3 comments · Fixed by #40

Comments

@RalfJung
Copy link
Collaborator

RalfJung commented Feb 6, 2023

We have only-target-foo and ignore-target-foo, matching the target triple. It would make just as much sense to also have only-host-foo and ignore-host-foo, matching the host triple.
@RalfJung RalfJung mentioned this issue Feb 7, 2023
Merged
@RalfJung
Copy link
Collaborator Author

RalfJung commented Feb 7, 2023

It would also be nice to have host versions of only-32bit etc. Though there the naming becomes a bit tricky...

@oli-obk oli-obk mentioned this issue Feb 7, 2023
Merged
@oli-obk
Copy link
Owner

oli-obk commented Feb 7, 2023

It would also be nice to have host versions of only-32bit etc. Though there the naming becomes a bit tricky...

Hmm... I guess if we'd switch to requiring only-target-32bit that should be fine, we can special case [0-9]+bit and make it not get processed as a target triple substring. A bit icky, but better than being even more verbose

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 7, 2023
@matthiaskrgr
Rollup merge of rust-lang#107756 - RalfJung:miri-out-of-addresses, r=…
d044c1b 
…oli-obk

miri: fix ICE when running out of address space

Fixes rust-lang/miri#2769
r? `@oli-obk`

I didn't add a test since that requires oli-obk/ui_test#38 (host must be 64bit and target 32bit). Also the test takes ~30s, so I am not sure if we want to have it in the test suite?
@RalfJung
Copy link
Collaborator Author

RalfJung commented Feb 7, 2023

we can special case [0-9]+bit and make it not get processed as a target triple substring

I don't think I like that. :/ but I don't have a better suggestion either.

RalfJung pushed a commit to RalfJung/miri that referenced this issue Feb 9, 2023
@matthiaskrgr
Rollup merge of #107756 - RalfJung:miri-out-of-addresses, r=oli-obk
edfce63 
miri: fix ICE when running out of address space

Fixes rust-lang#2769
r? `@oli-obk`

I didn't add a test since that requires oli-obk/ui_test#38 (host must be 64bit and target 32bit). Also the test takes ~30s, so I am not sure if we want to have it in the test suite?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a new filter scheme for host triples oli-obk/ui_test
2 participants
@RalfJung @oli-obk