DO NOT MERGE Fix #149 Heroku doesn't pick up changed environment variables #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the webpack build step from postinstall to start.
This makes bringing up a dyno slower (although the build is faster, so it should be the same total time for a new deployment), but the app picks up changes to environment variables without requiring a re-deploy.
This also brings another couple of benefits:
yarn start
runs the latest sources. This is typically what I want; the fact that it doesn't has got me a few times. (yarn run
is available to just run the production server, without building the client.)yarn install
no longer runs webpack. This was undesireable behavior (although fixing just this could have been accomplished by moving the build frompostinstall
toheroku-postbuild
).Description
Describe your changes here.
Required
Changes must conform to these requirements:
yarn test
passes. All new and existing tests pass.yarn lint
passes. All new code follows the code style of this project.Aspirational
We don't yet require these, but they are nice to have: