Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Fix #149 Heroku doesn't pick up changed environment variables #225

Closed
wants to merge 1 commit into from

Conversation

osteele
Copy link
Contributor

@osteele osteele commented May 9, 2018

Move the webpack build step from postinstall to start.

This makes bringing up a dyno slower (although the build is faster, so it should be the same total time for a new deployment), but the app picks up changes to environment variables without requiring a re-deploy.

This also brings another couple of benefits:

  • yarn start runs the latest sources. This is typically what I want; the fact that it doesn't has got me a few times. (yarn run is available to just run the production server, without building the client.)
  • yarn install no longer runs webpack. This was undesireable behavior (although fixing just this could have been accomplished by moving the build from postinstall to heroku-postbuild).

Description

Describe your changes here.

Required

Changes must conform to these requirements:

  • yarn test passes. All new and existing tests pass.
  • yarn lint passes. All new code follows the code style of this project.

Aspirational

We don't yet require these, but they are nice to have:

  • New code is covered by new or existing tests.
  • Changed code is covered by new or existing tests.

@kylecombes kylecombes temporarily deployed to abe-web-dev-pr-225 May 9, 2018 17:06 Inactive
@coveralls
Copy link

coveralls commented May 9, 2018

Pull Request Test Coverage Report for Build 341

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.609%

Totals Coverage Status
Change from base Build 337: 0.0%
Covered Lines: 157
Relevant Lines: 461

💛 - Coveralls

@kylecombes kylecombes temporarily deployed to abe-web-dev-pr-225 May 9, 2018 17:10 Inactive
@osteele osteele changed the title Fix #149 Heroku doesn't pick up changed environment variables NOT WORKING: Fix #149 Heroku doesn't pick up changed environment variables May 10, 2018
@osteele osteele self-assigned this May 10, 2018
@osteele osteele changed the title NOT WORKING: Fix #149 Heroku doesn't pick up changed environment variables NOT WORKING DO NOT MERGE: Fix #149 Heroku doesn't pick up changed environment variables May 10, 2018
@kylecombes kylecombes temporarily deployed to abe-web-dev-pr-225 May 16, 2018 14:16 Inactive
@osteele osteele changed the title NOT WORKING DO NOT MERGE: Fix #149 Heroku doesn't pick up changed environment variables Fix #149 Heroku doesn't pick up changed environment variables May 16, 2018
@osteele osteele changed the title Fix #149 Heroku doesn't pick up changed environment variables DO NOT MERGE Fix #149 Heroku doesn't pick up changed environment variables May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants