Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes #54, #175, #179 #217 #232

Merged
merged 1 commit into from
May 14, 2018
Merged

Completes #54, #175, #179 #217 #232

merged 1 commit into from
May 14, 2018

Conversation

osteele
Copy link
Contributor

@osteele osteele commented May 14, 2018

Description

The client fetches account info from the server, and uses this to
control the presentation of elements that require auth.

Required

Changes must conform to these requirements:

  • yarn test passes. All new and existing tests pass.
  • yarn lint passes. All new code follows the code style of this project.

Aspirational

We don't yet require these, but they are nice to have:

  • New code is covered by new or existing tests.
  • Changed code is covered by new or existing tests.

The client fetches account info from the server, and uses this to
control the presentation of elements that require auth.
@osteele osteele merged commit bb46d69 into dev May 14, 2018
@osteele osteele deleted the osteele/auth branch May 14, 2018 18:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 312

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 34.473%

Totals Coverage Status
Change from base Build 309: 0.0%
Covered Lines: 155
Relevant Lines: 443

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants