Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grayed out days display on month view #263

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Grayed out days display on month view #263

merged 1 commit into from
Nov 8, 2020

Conversation

ridunoff
Copy link
Collaborator

Description

Fixed the lastDay variable in actions.js to correctly represent the last day of the month in the month view.
Fixes issue #260

Testing

If the month ends on a Sunday, on the month view, check if events display in the final week's grayed out Monday-Saturday.

If the month ends on a Friday, on the month view, check if the grayed out events display on the grayed-out Saturday.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.245% when pulling 959b91d on iss260 into 299c983 on dev.

Copy link
Collaborator

@kylecombes kylecombes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my off-by-one mistake!

@ridunoff ridunoff merged commit 1064cd9 into dev Nov 8, 2020
@ridunoff ridunoff deleted the iss260 branch November 8, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants