Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resizing #18

Merged
merged 22 commits into from Apr 23, 2019
Merged

Implement resizing #18

merged 22 commits into from Apr 23, 2019

Conversation

labseven
Copy link
Collaborator

@labseven labseven commented Apr 13, 2019 •
edited by newsch

Make Resizing the terminal work properly, closes #13.

Need to implement storing canvas separately to be able to redraw the canvas after a resize.

Todo:

  • canvas_win doesn't refresh with canvas content before first keypress
  • backspace doesn't write to the canvas, only to the screen.
  • Implement panning

@labseven labseven mentioned this pull request Apr 13, 2019
Closed
@labseven labseven added the WIP Pull request not ready label Apr 13, 2019
@newsch newsch added this to the Week of 04/09 milestone Apr 13, 2019
@newsch newsch added this to In progress in Spring 2019 Project Tracking Apr 13, 2019
@newsch
Copy link
Member

newsch commented Apr 15, 2019 •
edited

I don't know if you're keeping a list of things to fix, but this is what I ran into:

  • canvas_win doesn't refresh with canvas content before first keypress
  • backspace doesn't write to the canvas, only to the screen.

@newsch newsch mentioned this pull request Apr 15, 2019
Merged
6 tasks
@labseven
Copy link
Collaborator Author

I need to separate the canvas (model) and window (view) better, those bugs (and probably more) will be fixed by this refactor.

@labseven labseven removed the WIP Pull request not ready label Apr 16, 2019
@labseven
Copy link
Collaborator Author

I think this is ready to be merged... let me know what you think!

@labseven labseven requested a review from newsch April 16, 2019 02:40
@labseven labseven added the WIP Pull request not ready label Apr 16, 2019
@labseven
Copy link
Collaborator Author

I've just rebased against master and am ready to merge things in!

@labseven
Copy link
Collaborator Author

Note: there is no way to switch to panning mode, as the picker is not implemented.
Also, KEY_ENTER is assigned wrong on my desktop.

@labseven labseven added interface enhancement New feature or request and removed WIP Pull request not ready labels Apr 23, 2019
Spring 2019 Project Tracking automation moved this from In progress to Reviewer approved Apr 23, 2019
MatthewBeaudouinLafon
MatthewBeaudouinLafon approved these changes Apr 23, 2019
View reviewed changes
Copy link
Collaborator

@MatthewBeaudouinLafon MatthewBeaudouinLafon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@labseven labseven merged commit 8502258 into master Apr 23, 2019
Spring 2019 Project Tracking automation moved this from Reviewer approved to Done Apr 23, 2019
@newsch newsch mentioned this pull request May 5, 2019
Closed
@labseven labseven deleted the adam/implement_resizing branch May 8, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewBeaudouinLafon MatthewBeaudouinLafon MatthewBeaudouinLafon approved these changes

@newsch newsch Awaiting requested review from newsch

Assignees
No one assigned
Labels
enhancement New feature or request interface
Projects
No open projects
Spring 2019 Project Tracking
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to resize canvas
3 participants
@labseven @newsch @MatthewBeaudouinLafon