Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting the Colla into our ASCII #67

Merged
merged 25 commits into from May 9, 2019

Conversation

labseven
Copy link
Collaborator

@labseven labseven commented May 9, 2019

Networking actually works!

It seemed to be dropping packets somewhere, need to look into that.

Closes #39

@labseven
Copy link
Collaborator Author

labseven commented May 9, 2019

It's not dropping packets now. Resize caused a sigsev on Evan's machine

@labseven
Copy link
Collaborator Author

labseven commented May 9, 2019

When a new terminal is opened, the other terminals sometimes do not read from the network socket until they are focused once.

@newsch newsch self-requested a review May 9, 2019 15:21
@newsch newsch added enhancement New feature or request network labels May 9, 2019
@newsch newsch added this to the MVP milestone May 9, 2019
@newsch newsch added this to To do in Spring 2019 Project Tracking via automation May 9, 2019
Spring 2019 Project Tracking automation moved this from To do to In progress May 9, 2019
Copy link
Member

@newsch newsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good. We can factor out the duplicated code with frontend.c later.

src/network.h Outdated Show resolved Hide resolved
src/server.c Outdated Show resolved Hide resolved
@newsch
Copy link
Member

newsch commented May 9, 2019

It works! Pretty fun to use too.

@labseven labseven mentioned this pull request May 9, 2019
@labseven labseven merged commit 638f667 into master May 9, 2019
Spring 2019 Project Tracking automation moved this from In progress to Done May 9, 2019
@labseven labseven deleted the initial-network-2-electric-boogaloo branch May 9, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request network
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Collaborate over the network
2 participants