Cleaner mode picking UI #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return ((mode - mode_first) + n) % (mode_list_end - mode_first) + mode_first; | ||
| } | ||
|
|
||
| Mode_ID next_canvas_mode(Mode_ID mode) { return add_mod_canvas_mode(mode, 1); } |
There was a problem hiding this comment.
Linter makes this look dumb with the one below, but not worth changing?
There was a problem hiding this comment.
I looked into this a little more, the option is AllowShortFunctionsOnASingleLine. I'll make another pull request to change it.
|
This looks pretty slick! Is there anything else you're thinking of doing here? |
Nope, that about covers it. If I think of anything else, I'll make a different pull request. |
newsch
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current canvas mode is highlighted (reverse video) in mode picker.
Use TAB and Shift TAB to cycle through modes in mode picker. ENTER to commit to a mode.