Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service metadata #29

Closed
ahmed-t-mpc opened this issue Feb 28, 2019 · 4 comments
Closed

Add support for service metadata #29

ahmed-t-mpc opened this issue Feb 28, 2019 · 4 comments
Assignees

Comments

@ahmed-t-mpc
Copy link

Hello. Doesn't the library support service-specific metadata (https://www.consul.io/api/agent/service.html#meta) or is there a way to assign metadata to a service after registering it ?

@oliora
Copy link
Owner

oliora commented Feb 28, 2019

No, neither getting or setting metadata is not supported but it should be easy to add this feature if needed.

@ahmed-t-mpc
Copy link
Author

ahmed-t-mpc commented Feb 28, 2019

No, neither getting or setting metadata is not supported but it should be easy to add this feature if needed.

Thanks for your quick answer. I was planning to use that feature so don't hesitate to add it if you can, it's a standard feature of Consul and other libraries support it. Other than that, congratulations for this helpful library.

@oliora oliora changed the title Service metadata ? Add support for service metadata Mar 1, 2019
@oliora oliora self-assigned this Mar 1, 2019
oliora added a commit that referenced this issue Mar 4, 2019
@oliora
Copy link
Owner

oliora commented Mar 4, 2019

Both registering service with metadata and retrieving one is supported.

@oliora oliora closed this as completed Mar 4, 2019
@ahmed-t-mpc
Copy link
Author

Thank you very much. I'll give it a try this week.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants