Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Zeep instead of Suds #85

Merged
merged 2 commits into from
Aug 28, 2017
Merged

use Zeep instead of Suds #85

merged 2 commits into from
Aug 28, 2017

Conversation

jairhenrique
Copy link
Contributor

@osantana @georgeyk can someone help in rewriting vrc's files, and fix tests.
When I delete vcr files, authentication fail.

.editorconfig Outdated
@@ -0,0 +1,12 @@
# EditorConfig is awesome: http://EditorConfig.org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, exclude this file.

Copy link

@deniscostadsc deniscostadsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not passing. Fiz them and we are going to review as soon as possible

Copy link

@deniscostadsc deniscostadsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not passing. Fiz them and we are going to review as soon as possible

@luizdepra
Copy link
Contributor

@jairhenrique, normally we just need to delete the cassette files and run the tests again. It will regenerate cassette files automatically.
Can you post the error log here?

@jairhenrique
Copy link
Contributor Author

@luizdepra I create 2 gist files with responses.

1 - Creating new vcr files: https://gist.github.com/jairhenrique/c44318d81027f6ff2760555e5533485d

2 - With existing vcr files: https://gist.github.com/jairhenrique/8e9403721c666b41d8103512eb5628f2

@jairhenrique
Copy link
Contributor Author

@luizdepra on master if I delete vcr files and run tests with suds, tests fails too.

@georgeyk
Copy link
Contributor

georgeyk commented Jul 5, 2017

@jairhenrique I'll try to reach someone with valid credentials to generate those cassettes. Please bear with us.
thx

@lamenezes
Copy link
Contributor

Hi,

Firstly, thank you for the pull request. We use aiohttp vastly at @olist and it would be great to use a soap client that supports it. 🙂

Secondly, I'm the someone with valid credentials and on this moment I'm generating the cassettes. On the meanwhile, @jairhenrique , would you please check the errors that aren't related to vcr [1]?

[1] https://travis-ci.org/olist/correios/jobs/250019681#L701-L921

@lamenezes
Copy link
Contributor

I just created new cassettes using the credentials I have. Even with that there are some tests failing. Probably we need another credentials. We'll try to fix that as soon as we can.

@osantana
Copy link
Contributor

@jairhenrique I'll return from my vacation in Aug, 3. As soon I return I'll take a look at this PR and help you to fix the broken tests.

@osantana
Copy link
Contributor

hooray! kudos to @jairhenrique!

I'm 👍 for this PR.

Copy link
Contributor

@luizdepra luizdepra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Copy link
Contributor

@caiocarrara caiocarrara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks!

@luizdepra luizdepra merged commit ae57384 into olist:master Aug 28, 2017
@osantana
Copy link
Contributor

Released 3.0.0
Submitting dist/correios-3.0.0.tar.gz to https://upload.pypi.org/legacy/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants