-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Zeep instead of Suds #85
Conversation
.editorconfig
Outdated
@@ -0,0 +1,12 @@ | |||
# EditorConfig is awesome: http://EditorConfig.org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, exclude this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not passing. Fiz them and we are going to review as soon as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are not passing. Fiz them and we are going to review as soon as possible
@jairhenrique, normally we just need to delete the cassette files and run the tests again. It will regenerate cassette files automatically. |
@luizdepra I create 2 gist files with responses. 1 - Creating new vcr files: https://gist.github.com/jairhenrique/c44318d81027f6ff2760555e5533485d 2 - With existing vcr files: https://gist.github.com/jairhenrique/8e9403721c666b41d8103512eb5628f2 |
@luizdepra on |
@jairhenrique I'll try to reach someone with valid credentials to generate those cassettes. Please bear with us. |
Hi, Firstly, thank you for the pull request. We use Secondly, I'm the someone with valid credentials and on this moment I'm generating the cassettes. On the meanwhile, @jairhenrique , would you please check the errors that aren't related to vcr [1]? [1] https://travis-ci.org/olist/correios/jobs/250019681#L701-L921 |
I just created new cassettes using the credentials I have. Even with that there are some tests failing. Probably we need another credentials. We'll try to fix that as soon as we can. |
@jairhenrique I'll return from my vacation in Aug, 3. As soon I return I'll take a look at this PR and help you to fix the broken tests. |
hooray! kudos to @jairhenrique! I'm 👍 for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks!
Released 3.0.0 |
@osantana @georgeyk can someone help in rewriting vrc's files, and fix tests.
When I delete vcr files, authentication fail.