Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use local wsdl files to improve client load #90

Merged
merged 2 commits into from
Aug 29, 2017

Conversation

jairhenrique
Copy link
Contributor

No description provided.

@osantana
Copy link
Contributor

It would be nice to have a CLI script to check/update WSDL files.

@jairhenrique
Copy link
Contributor Author

@osantana 86309f7

@osantana
Copy link
Contributor

@osantana 86309f7

💄 add a newline at the end of Makefile

@jairhenrique
Copy link
Contributor Author

💄 add a newline at the end of Makefile
This project has no .editorconfig 😞

@osantana
Copy link
Contributor

This project has no .editorconfig 😞

Create one :)

@jairhenrique
Copy link
Contributor Author

Create one :)

¯\(ツ)#85 (review)

@osantana
Copy link
Contributor

¯(ツ)/¯ #85 (review)

@georgeyk can we add a .editorconfig? It's a "standard" for editors and IDEs configuration.

@georgeyk
Copy link
Contributor

@osantana I think it's mainly for IDE's, but OK if it will help.

@osantana
Copy link
Contributor

@osantana I think it's mainly for IDE's, but OK if it will help.

It's generic: https://github.com/editorconfig/editorconfig-vim

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #90 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   98.98%   98.98%   +<.01%     
==========================================
  Files          11       11              
  Lines        1569     1572       +3     
==========================================
+ Hits         1553     1556       +3     
  Misses         16       16
Impacted Files Coverage Δ
correios/utils.py 100% <100%> (ø) ⬆️
correios/client.py 97.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e556db5...f60a01d. Read the comment docs.

@osantana osantana merged commit 244f42c into olist:master Aug 29, 2017
@jairhenrique jairhenrique deleted the jh-local_wsdl branch August 29, 2017 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants