Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image support #12

Closed
itsmattkc opened this issue Jan 29, 2018 · 5 comments
Closed

Image support #12

itsmattkc opened this issue Jan 29, 2018 · 5 comments

Comments

@itsmattkc
Copy link
Contributor

No description provided.

@itsmattkc
Copy link
Contributor Author

This happens to coincide with image support in general, which is known to return a glitched frame and occasionally crashes the program. Basic support for "infinite length" media has been added, but so far this has only been tested to work with imported plaintext documents (a feature that will likely go unused by the majority of users).

itsmattkc added a commit that referenced this issue Feb 16, 2018
@itsmattkc itsmattkc changed the title Image sequence support Image support Feb 17, 2018
@itsmattkc
Copy link
Contributor Author

FFmpeg has provided mixed results on image decoding so far. Many images simply don't decode at all (infamous "bad src pointers" error), but some do. I'm now considering using SDL directly to read image data instead, but this may prove difficult with the myriad of containers out there (unless some FFmpeg demux->SDL chain is possible, but that sounds needlessly complex). Additionally it's proving hard to use FFmpeg to determine if an input is a still image or not. FFmpeg seems to have no built-in detection for this, meaning Olive might have to directly read the codec ID to make that determination.

@itsmattkc
Copy link
Contributor Author

Clarification: Olive can currently read JPEG files using FFmpeg. It cannot read PNG files.

@itsmattkc
Copy link
Contributor Author

PNG/TIFF remains unreadable using FFmpeg. Still leaning towards pure SDL solution.

itsmattkc added a commit that referenced this issue Mar 7, 2018
@itsmattkc
Copy link
Contributor Author

Once again, this issue was caused by Olive misusing FFmpeg libs. Early on in development, FFmpeg's multithreading was enabled because it immensely improved video playback across the board. Turns out it also destroys any attempt to read PNG/TIFF files specifically (BMP/JPEG have worked fine for a while). Olive now doesn't enable multithreading on these codecs which solved this issue.

This also fixed/added PSD support, however it appears libavcodec can only read PSDs saved with "Maximize Compatibility" enabled in Photoshop.

Playing a sequence now could now be achieved. FFmpeg (the program) can interpret image sequences, so it's a question of whether the libs have a built in function for this or if Olive will have to handle each image and pass it to libavcodec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant