Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H.264 seeking is inaccurate #18

Closed
itsmattkc opened this issue Jan 30, 2018 · 2 comments
Closed

H.264 seeking is inaccurate #18

itsmattkc opened this issue Jan 30, 2018 · 2 comments
Assignees

Comments

@itsmattkc
Copy link
Contributor

This appears to be due to an underlying flaw in the FFmpeg API and leads to the symptoms described in #11 and #15 . When Olive tries to seek to a specific frame, it attempts to seek to the closest keyframe before the target frame and then play all frames up until that point to retrieve the target frame accurately. Unfortunately after seeking an H.264 video, FFmpeg appears to stay in the old location for 1-3 frames before actually performing the seek. This may affect other codecs too, but so far H.264 is the only codec that appears with the bug. This does not affect codecs with All-I frames (e.g. ProRes) and also does not appear to affect msvideo1.

@itsmattkc itsmattkc added the bug label Jan 30, 2018
@itsmattkc itsmattkc self-assigned this Jan 30, 2018
@itsmattkc
Copy link
Contributor Author

This bug can be seen especially clearly trying to step back frame-by-frame through an H.264 video. Olive does not step back smoothly. Instead it appears to alternate between playing the next frame and then stepping back.

@itsmattkc
Copy link
Contributor Author

Turns out this was not an FFmpeg bug, this was caused by neglecting to flush the codec buffers before seeking. This has now been fixed as of 0a4832c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant