Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit tool does not select linked clips #27

Closed
itsmattkc opened this issue Feb 11, 2018 · 6 comments
Closed

Edit tool does not select linked clips #27

itsmattkc opened this issue Feb 11, 2018 · 6 comments

Comments

@itsmattkc
Copy link
Contributor

When splitting a clip (either with razor or edit tool), the newly spawned clips will continue to reference the old clips as linked.

The razor/edit tool in general need to be aware of linked clips which currently they aren't.

@itsmattkc itsmattkc added the bug label Feb 11, 2018
@itsmattkc
Copy link
Contributor Author

When a clip gets "split", it runs a copy command to essentially make a perfect duplicate of itself. Obviously, duplicating the linked clips was not as good of an idea as it seemed at the time. This has been fixed, however it would be nice if Olive was self-aware enough to re-link clips if a bunch of them were clicked.

I'll leave this issue open, but I will put it on the backburner as it is no longer as app-breaking as it was before.

@itsmattkc
Copy link
Contributor Author

If two clips are linked and one of them is removed, sometimes selecting the remaining clip will also make a blank selection where the other linked clip used to be.

@itsmattkc
Copy link
Contributor Author

^ above fixed

@itsmattkc
Copy link
Contributor Author

itsmattkc commented Jun 12, 2018

Basic support for splitting clips and relinking added. Support for the following still needs adding:

  • Relinking after deleting a selection
  • Relinking after splitting a selection
  • Edit tool selecting linked clips
  • Undo/redo unlinks all clips (now tracked in Undo/redo system is dysfunctional #72)

@itsmattkc itsmattkc added urgent and removed urgent labels Jun 14, 2018
@itsmattkc itsmattkc changed the title Linked clip glitches Edit tool does not select linked clips Jun 20, 2018
@itsmattkc
Copy link
Contributor Author

It looks like implementing this will be fairly challenging, and I'm not even certain it'd actually be desirable. The edit tool isn't really for "per clip" manipulation, it's more for large spans of timeline area.

A way to implement this would be to make a separate "add to selection" function that checks for a selection on that track with those in/out points, and if they're covered, add them to an existing (otherwise just make a new selection object). This would also fix a potential future problem once you can make multiple edit tool selections by holding shift (not yet implemented) to prevent you from selecting the same area twice. It would be less efficient than the current code, but the functionality may outweigh it.

@itsmattkc
Copy link
Contributor Author

Finally implemented this (using a better algorithm than the aforementioned as alluded to in #86). I was considering not implementing this at all for a while because it felt like it might be awkward. But since I didn't know, and the select code had been cleaned up to allow for this to be added relatively easily, I gave it a shot. Honestly, personally, I do find it awkward, but I can also see how it might be more intuitive for some people (which is also why I didn't dismiss it despite thinking there was a chance it wouldn't work). Therefore, it is now fully implemented and exists, but it's been disabled by default. This functionality can be added by checking "Edit Tool Selects Links" from the "Tools" menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant