Errors #510
Merged
Errors #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sync.read because there was an error that wasn't getting caught in the async api
edi9999
reviewed
Aug 5, 2018
| jimpInstance.emitError('constructor', err); | ||
| } else { |
There was a problem hiding this comment.
I am not sure why you want to change the behavior of this ?
There was a problem hiding this comment.
(The rest looks good to me)
There was a problem hiding this comment.
If jimp emits the error then the callback will never be called with error, and the promise never catches the error. this change makes it so that jimp either
- calls the callback with the error
- rejects with the error
- or if no callback or promise is provided it emits the error
when we were calling emitError the whole exectution of the program would stop if you didn't have an on('error'). All the issues basically arose from just this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #420
closes #422
closes #454
closes #347
closes #353
closes #408
Small code change, big impact 🎉