Aggregations returned as base64 encoded string (json.RawMessage)

[vsiv]

if you json.Marshal(result) on query result with aggregations, the aggregation results are marshaled as a base64 encoded string , whereas the query hits are not, which is a bit of a hassle. You can test it by marshaling the result from a query execution that uses aggregation. I tested with TermsAggregation.

You can solve it by using result.Aggregations... but not for entire result response.

type Aggregations map[string]json.RawMessage

Its because json.RawMessage is not a pointer (reference: https://groups.google.com/forum/#!topic/Golang-Nuts/38ShOlhxAYY).

Changing it to type Aggregations map[string]*json.RawMessage along with its usage in search_aggs.go solves it :) But I am not sure about other ramifications due to this.

If you like this, I can submit a pull request. For now, I have just forked the repo.

Thanks.

[olivere]

Thanks for reporting this. You learn a new thing every day. :-)
Yes, maybe I should change that. Give me some time to think about it.

[olivere]

Can you test if the issue-51 branch solves the issue for you? If you can, it would be very helpful if you can provide a test for it...

[olivere]

FYI: Marshaling results back into JSON is not tested in Elastic. There might be issues with fields not being attributed with omitempty etc. You've been warned :-)

[sevein]

Thank you so much for this, I was experiencing the same issue today! go get -u et voilà! 👍

[olivere]

@sevein My pleasure. May I ask what's your use case for serializing the results back into JSON?

[sevein]

Of course, @olivere! I was basically doing a bad thing :) i.e. embedding the serialized version of elastic.Aggregations into my HTTP API response. But I've decided to start building my custom response types with its own json tags after seeing your warning in c3351fa. Thanks again!

[vsiv]

Thanks! @olivere, sorry was really caught up the last couple weeks... couldn't help