New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interface for calling the C++ code #14
Open
misharash
wants to merge
142
commits into
oliverphilcox:master
Choose a base branch
from
misharash:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and other minor fixes
Hopefully they are clearer now
Also changed the logic a bit in ordinary jackknife
Centralized c2 diagonalization Combined two loading functions to one
The code was made installable and was tested in the meantime. Still need to update the docs. |
Because multi-threading in it is known to interfere with RascalC
by building additional verbose executable versions
The covariance has not converged + some extra variants not cleaned up
Thanks to Jiaxi Yu for pointing this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining change: python function wrapper that launches the main computation.
Currently realized by writing the temporary files and invoking the appropriate pre-built binary on command line automatically for the user.
Worth a major version (3.0) in my opinion.
Also restructured most of the scripts, in each one wrapped the full procedure as well as its reusable parts into functions.
TODO: