feat(ui): Toggle section display when clicking on label

This seems more useful, as toggling section automation is less commonly required.
oliversalzburg · Jul 17, 2021 · 09a2ddd · 09a2ddd
1 parent 14633c5
commit 09a2ddd
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 12 deletions.
diff --git a/packages/userscript/source/ui/BonfireSettingsUi.ts b/packages/userscript/source/ui/BonfireSettingsUi.ts
@@ -29,9 +29,9 @@ export class BonfireSettingsUi extends SettingsSectionUi<BonfireSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/CraftSettingsUi.ts b/packages/userscript/source/ui/CraftSettingsUi.ts
@@ -32,9 +32,9 @@ export class CraftSettingsUi extends SettingsSectionUi<CraftSettings> {
     const element = $("<li/>", { id: `ks-${toggleName}` });
 
     const label = $("<label/>", {
-      for: `toggle-${toggleName}`,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: `toggle-${toggleName}`,

diff --git a/packages/userscript/source/ui/DistributeSettingsUi.ts b/packages/userscript/source/ui/DistributeSettingsUi.ts
@@ -28,9 +28,9 @@ export class DistributeSettingsUi extends SettingsSectionUi<DistributeSettings>
     const element = $("<li/>", { id: `ks-${toggleName}` });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/EngineSettingsUi.ts b/packages/userscript/source/ui/EngineSettingsUi.ts
@@ -22,7 +22,7 @@ export class EngineSettingsUi extends SettingsSectionUi<EngineSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
+      //for: "toggle-" + toggleName,
       text: itext,
     });
 

diff --git a/packages/userscript/source/ui/FilterSettingsUi.ts b/packages/userscript/source/ui/FilterSettingsUi.ts
@@ -28,9 +28,9 @@ export class FiltersSettingsUi extends SettingsSectionUi<FilterSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/OptionsSettingsUi.ts b/packages/userscript/source/ui/OptionsSettingsUi.ts
@@ -28,9 +28,9 @@ export class OptionsSettingsUi extends SettingsSectionUi<OptionsSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/ReligionSettingsUi.ts b/packages/userscript/source/ui/ReligionSettingsUi.ts
@@ -30,9 +30,9 @@ export class ReligionSettingsUi extends SettingsSectionUi<ReligionSettings> {
     const element = $("<li/>", { id: `ks-${toggleName}` });
 
     const label = $("<label/>", {
-      for: `toggle-${toggleName}`,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: `toggle-${toggleName}`,

diff --git a/packages/userscript/source/ui/SpaceSettingsUi.ts b/packages/userscript/source/ui/SpaceSettingsUi.ts
@@ -29,9 +29,9 @@ export class SpaceSettingsUi extends SettingsSectionUi<SpaceSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/TimeControlSettingsUi.ts b/packages/userscript/source/ui/TimeControlSettingsUi.ts
@@ -34,9 +34,9 @@ export class TimeControlSettingsUi extends SettingsSectionUi<TimeControlSettings
     const element = $("<li/>", { id: `ks-${toggleName}` });
 
     const label = $("<label/>", {
-      for: `toggle-${toggleName}`,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: `toggle-${toggleName}`,

diff --git a/packages/userscript/source/ui/TimeSettingsUi.ts b/packages/userscript/source/ui/TimeSettingsUi.ts
@@ -29,9 +29,9 @@ export class TimeSettingsUi extends SettingsSectionUi<TimeSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/TradingSettingsUi.ts b/packages/userscript/source/ui/TradingSettingsUi.ts
@@ -30,9 +30,9 @@ export class TradingSettingsUi extends SettingsSectionUi<TradingSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,

diff --git a/packages/userscript/source/ui/UnlockingSettingsUi.ts b/packages/userscript/source/ui/UnlockingSettingsUi.ts
@@ -28,9 +28,9 @@ export class UnlockingSettingsUi extends SettingsSectionUi<UnlockingSettings> {
     const element = $("<li/>", { id: "ks-" + toggleName });
 
     const label = $("<label/>", {
-      for: "toggle-" + toggleName,
       text: itext,
     });
+    label.on("click", () => this._itemsButton.trigger("click"));
 
     const input = $("<input/>", {
       id: "toggle-" + toggleName,