Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression bug fix - API method name change. #19

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Regression bug fix - API method name change. #19

merged 2 commits into from
Dec 3, 2019

Conversation

jaminmelville
Copy link
Contributor

Fixes error thrown when trying to run VectorBender on a point layer.

Method name in class QgsGeometry updated from fromPoint to fromPointXY as a result of breaking change in QGIS API going between versions 2 and 3.

@jaminmelville jaminmelville mentioned this pull request Mar 25, 2019
Closed
zezzagio
zezzagio reviewed Apr 1, 2019
View reviewed changes
Copy link

@zezzagio zezzagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you omitted to fix the multipoint transformation, which has the same problem: from "QgsGeometry.fromMultiPoint( newListA )" to "QgsGeometry.fromMultiPointXY( newListA )"

@jaminmelville
Copy link
Contributor Author

It seems you omitted to fix the multipoint transformation, which has the same problem: from "QgsGeometry.fromMultiPoint( newListA )" to "QgsGeometry.fromMultiPointXY( newListA )"

Thanks @zezzagio! I've added another commit which addresses this also 👍

@stucraw stucraw mentioned this pull request Nov 19, 2019
Closed
@olivierdalang olivierdalang merged commit e7e4130 into olivierdalang:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zezzagio zezzagio zezzagio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaminmelville @zezzagio @olivierdalang