Character Importance-Slider memorize importance of last character ... partly #102
Comments
|
Thanks for reporting that. Annoying stuff... I'll have a look when possible. |
… value See issue olivierkes#102. By default when a character is added to the character model, the importance value is set to "0" (Minor). However when the new character is selected, the importance slider remains set to the value of the previously selected character. Steps to Reproduce: 1. Click add character (plus sign) button. 2 Select this "New character". 3. Select "Basic infos" tab and change Name to "Bob". 4. Move Importance slider all the way to the right (Main). 4. Click add character (plus sign) button. 5. Select this "New character". Note that the "New character" is shown in the character list pane under "Minor", but the Importance slider is still all the way to the right (Main). This enhancement ensures that the corresponding character UI importance slider is also set to the same default value.
|
@ScullyBlue I created a Pull Request to address this issue. The PR enhancement makes the Character Importance slider work the same way as the Plot Importance slider currently works. More specifically with the enhancement, newly added records will default to the lowest importance. This seemed to me to be a more correct choice because a user could be on any Character Tab (Basic infos, Summary, Notes, Detailed Infos) when the + button is clicked to add a new character. Only the Basic infos tab shows the Importance slider, which is a piece of data for the current character only. |
… value See issue olivierkes#102. By default when a character is added to the character model, the importance value is set to "0" (Minor). However when the new character is selected, the importance slider remains set to the value of the previously selected character. Steps to Reproduce: 1. Click add character (plus sign) button. 2. Select this "New character". 3. Select "Basic infos" tab and change Name to "Bob". 4. Move Importance slider all the way to the right (Main). 5. Click add character (plus sign) button. 6. Select this "New character". Note that the "New character" is shown in the character list pane under "Minor", but the Importance slider is still all the way to the right (Main). This enhancement ensures that the corresponding character UI importance slider is also set to the same default value.
…e slider See issue olivierkes#102. By default when a character is added to the character model, the importance value is set to "0" (Minor). However when the new character is selected, the importance slider remains set to the value of the previously selected character. Steps to Reproduce: 1. Click add character (plus sign) button. 2. Select this "New character". 3. Select "Basic infos" tab and change Name to "Bob". 4. Move Importance slider all the way to the right (Main). 5. Click add character (plus sign) button. 6. Select this "New character". Note that the "New character" is shown in the character list pane under "Minor", but the Importance slider is still all the way to the right (Main). This enhancement ensures that the corresponding character UI importance slider is also set to the proper character importance.
|
Thanks, gedakc, that sounds good. |
|
My fault, wrong button ... |
|
The above referenced fixes have been committed to the develop branch for inclusion in the upcoming 0.5.0 release. |
|
@olivierkes can you close this report? The fix to address the issue has already been committed (see above). |
I have created one character with high importance (Main) and when I create a new one, the importance-slider is also on high importance, but in the sidebar the second character stand under low importance (Minor). If I want the character move to the category Main I must set the importance-slider back to Minor and then to Main.
Not very important, but at first it confused me, because the importance of the character was high (on Slider) and the character stands in the list under low importance.
I used manuscript 0.3.0 on Linux Mint 18, 64-bit.
The text was updated successfully, but these errors were encountered: