Spell checker is active for partial words.

[vithiri]

I am not certain if this is a feature or a bug, but the spell checker is active even when a word has not been completed.

If I type "paragraph", the spell checker will kick in and highlight the word at "parag" since it's not a proper word (yet).

Could a better behaviour be to only check words for spelling once a space or a special character has been added by the end of it?

[olivierkes]

Good point. I tried a few options, but wasn't able to find a satisfying one.

The relevant code is this:

manuskript/manuskript/ui/editors/basicHighlighter.py

Lines 82 to 87 in 3b1a3f7

	# Spell checking
	# Based on http://john.nachtimwald.com/2009/08/22/qplaintextedit-with-in-line-spell-check/
	WORDS = '(?iu)[\w\']+'
	if hasattr(self.editor, "spellcheck") and self.editor.spellcheck:
	for word_object in re.finditer(WORDS, text):
	if self.editor._dict and not self.editor._dict.check(word_object.group()):

WORDS = '(?iu)([\w\']+)\W' is the regex used to match words ((?iu) means: case insensitive, unicode). Now if I use '(?iu)[\w\']+\W', so I add "followed by a non-word character" \W (code has to be slightly modified, see below), then it will work as desired when typing, but it won't spellcheck words at the end of line:

(Code has to be modify like that:)

WORDS = '(?iu)([\w\']+)\W'  # ← added a capturing group on the word
if hasattr(self.editor, "spellcheck") and self.editor.spellcheck:
    for word_object in re.finditer(WORDS, text):
        if self.editor._dict and not self.editor._dict.check(word_object.group(1)):  # ← spell check the group

Maybe somebody has a better idea?

[olivierkes]

Maybe somebody has a better idea?

Well actually I do... I add a space at the end of every checked line, except if the text cursor is there:

manuskript/manuskript/ui/editors/basicHighlighter.py

Lines 84 to 91 in ee058a3

	# Following algorithm would not check words at the end of line.
	# This hacks adds a space to every line where the text cursor is not
	# So that it doesn't spellcheck while typing, but still spellchecks at
	# end of lines. See github's issue #166.
	textedText = text
	if self.currentBlock().position() + len(text) != \
	self.editor.textCursor().position():
	textedText = text + " "

Please test (on branch future) and confirm whether that behavior is better or not :)

[vithiri]

The behavior is clearly much better now, but an observation would be that it extends the wavy line to include the word terminator as well, whether that's the tailing space or a non word character -- but seemingly only the first one.

Here is a word that is behaving strangely, most likely due to the "special character" actually being a part of the word -- the wavy line goes away after adding a space by the end of the word:

[olivierkes]

it extends the wavy line to include the word terminator as well (...)

Yep, stupid mistake. Fixed :)

Here is a word that is behaving strangely (...)

Previous commit should fix that too:

It showed me another issue: in some cases, right-click does not select the same word to suggest corrections:

Memo: I need to correct that here: WordUnderCursor does not allow for quotation mark ' it seems:

manuskript/manuskript/ui/views/textEditView.py

Lines 407 to 412 in 3b1a3f7

	# Select the word under the cursor.
	# But only if there is no selection (otherwise it's impossible to select more text to copy/cut)
	cursor = self.textCursor()
	if not cursor.hasSelection():
	cursor.select(QTextCursor.WordUnderCursor)
	self.setTextCursor(cursor)

[vithiri]

I noticed that both FocusWriter and Gedit suffer from the same issue where the word will be underlined as misspelled if i.e. shouldn' is typed, so perhaps this behavior is simply inherent in the spell checking.

[olivierkes]

(That was closed in 0.5.0 but I forgot to close it)

[vithiri]

@gedakc @olivierkes Did this issue nestle its way back in again at some point?

[gedakc]

Good catch @vithiri. I preformed a git bisect and it appears that the problem with the spell checker being active while typing a word came back in 0.7.0 with commit 63b471e which fixed issue #283.

I will take a look at this.