Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when project file is open in another application #950

Closed
unappendixed opened this issue Oct 20, 2021 · 0 comments · Fixed by #1004
Closed

Crash when project file is open in another application #950

unappendixed opened this issue Oct 20, 2021 · 0 comments · Fixed by #1004
Labels
bug
Milestone
0.14.0

Comments

@unappendixed
Copy link

Stumbled onto this one accidentally.

Windows 10
Manuskript 0.12.0

It appears that if Manuskript attempts to save to the .msk file (presumably folder-based projects are unaffected) that is open in another application (7Zip in my case) it causes an instant crash with no error message.

Error handling should probably be implemented in case of the write location being locked/dirty, along with a little message box to let the user know that by having the file open they're preventing their project from being saved.
jdanielp added a commit to jdanielp/manuskript that referenced this issue Jan 25, 2022
@jdanielp
Fix crash when files are locked for writing (Fixes olivierkes#950)
ea6ac1c 
Wrap file opens in try-catch
Applied fix for project file as well as other files that are opened during save
jdanielp added a commit to jdanielp/manuskript that referenced this issue Jan 25, 2022
@jdanielp
Fix crash when files are locked for writing (Fixes olivierkes#950)
eb654c2 
Wrap file opens in try-catch
Applied fix for project file as well as other files that are opened during save
jdanielp added a commit to jdanielp/manuskript that referenced this issue Jan 25, 2022
@jdanielp
Fix crash when files are locked for writing (Fixes olivierkes#950)
37667ed 
Wrap file opens in try-catch
Applied fix for project file as well as other files that are opened during save
@TheJackiMonster TheJackiMonster linked a pull request Jan 25, 2022 that will close this issue
Fix crash when files are locked for writing (Fixes olivierkes#950) #1004
Merged
@TheJackiMonster TheJackiMonster added this to the 0.14.0 milestone Jan 25, 2022
jdanielp added a commit to jdanielp/manuskript that referenced this issue Jan 29, 2022
@jdanielp
Add generic list dialog, use it to show files that cannot be saved (f…
f63acaf 
…ixes olivierkes#950)
jdanielp added a commit to jdanielp/manuskript that referenced this issue Jan 29, 2022
@jdanielp
Fix crash on open with locked files (fixex olivierkes#950)
5a6d68e
jdanielp added a commit to jdanielp/manuskript that referenced this issue Feb 10, 2022
@jdanielp
apply patch per PR feedback to avoid segfault (fixes olivierkes#950)
750b96e
TheJackiMonster added a commit that referenced this issue Mar 30, 2022
@TheJackiMonster
Merge pull request #1004 from jdanielp/fix-olivierkes-950
daf456e 
Fix crash when files are locked for writing (Fixes #950)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Fix crash when files are locked for writing (Fixes olivierkes#950) jdanielp/manuskript
2 participants
@TheJackiMonster @unappendixed