Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when changing index card style #992

Closed
amconners opened this issue Jan 14, 2022 · 2 comments · Fixed by #999
Closed

Crash when changing index card style #992

amconners opened this issue Jan 14, 2022 · 2 comments · Fixed by #999
Labels
Milestone

Comments

@amconners
Copy link
Contributor

Clicking the "Old style" option in Settings -> Views -> Index Cards causes Manuskript to instantly crash with the following output:

CRITICAL> An unhandled exception has occurred!
Traceback (most recent call last):
  File "/usr/share/manuskript/manuskript/ui/views/corkDelegate.py", line 214, in paint
    self.paint_v1(p, option, index)
  File "/usr/share/manuskript/manuskript/ui/views/corkDelegate.py", line 491, in paint_v1
    r = self.mainLineRect.adjusted(-m, -m, m, m / 2)
TypeError: adjusted(self, int, int, int, int): argument 4 has unexpected type 'float'
WARNING> QPaintDevice: Cannot destroy paint device that is being painted

This was in Manuskript 0.13.1 on Arch Linux, installed via the package repository.

@siliconserf
Copy link
Contributor

It didn't happen when I exercised the options on my Windows 10 machine, suggesting the issue is in the Linux interface.

@TheJackiMonster
Copy link
Collaborator

It's probably related to the changes in newer Python. The Windows version uses an older Python version to stay compatible with older Windows versions. This will probably just require an explicit cast to int which older Python versions handle implicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants