Avoid crash on spellcheck by ensuring enchant dictionary exists #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it doesn't cost much in terms of performance to add a check in |
|
Thanks for your input. I will add a check for dictionary existence to each call of |
gedakc
force-pushed
the
issue-273-spellcheck-crash
branch
from
26d1f2f
to
6291894
Compare
|
Hi @olivierkes, I added the extra check to ensure that the spelling dictionary is set. Note that I merged the enhancement into the original commit so that there is only only commit point. If you prefer separate commits then let me know and I will do that in the future. If you are busy, then also let me know and then I will proceed to push this and other outstanding commits to the develop branch. Best wishes, |
gedakc
force-pushed
the
issue-273-spellcheck-crash
branch
from
6291894
to
43c0775
Compare
|
This PR has been merged into the develop branch to be included in the next release of Manuskript. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #273.
@olivierkes do you think we should also test for dictionary existence in textEditView::setDict(self, d), or is this only called using a known to exist dictionary listed in the GUI?