New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misc. typos #489
Fix misc. typos #489
Conversation
Thank you @luzpaz for your interest in Manuskript and your efforts to make it better. This PR identifies a number of spelling mistakes to fix which is a good thing. However some of the spelling changes involve automatically generated content, and one spelling change affects executable code. As such I have some suggestions for this Pull Request.
|
I will follow-up when I have another moment. Thanks. |
@luzpaz What is the status on this? |
forgot about this. Will look in to it |
Split off from olivierkes#489
Can you rebase your entire set of changes against the current develop branch? I am not entirely sure happened here, but I think you left your Feb 10 changes in (8830ea1), pulled in new more recent changes from develop, and then wrote these new patches against your old patch, leading to the commits where you 'revert'. Ideally your PR only has the 'Misc. typos' and 'Add a few more typos' fixes. (And even those can be squashed together into a single commit. Edit: Nevermind. Github confused me with the old date. It seems like everything is properly on top of the current develop. All you need is a squash. |
squashed and ready to go |
I'd amend the commit message a bit still because some of that description doesn't make sense anymore now that you've tidied it up. Other than that, it looks good! 👍 |
Found via `codespell -q 3 -S *.ts,./libs,./sample-projects -L searchin`
Yea, makes sense. Amended. |
@luzpaz are you able to make the suggested "save" -> "saved" changes in the next day or so? If not then I will plan to merge this as-is and make the change afterwards. |
@gedakc i don't follow? was there a suggestion that I missed ? |
This looks like my bad. I must have been reviewing an older commit in my comments above. When pulled your changes into my local repo, I can clearly see that you did change "save" to "saved" in both the files:
I will plan to merge this PR for inclusion in the next release of Manuskript. Thank you for your help. |
@luzpaz no worries. I just remembered that yesterday I had pulled down your other PR with the typo fixes and then had made the "save" -> "saved" change locally. But with all the other work I did yesterday I forgot. I'm glad you double-checked. I will merge this with the develop branch after the current Travis CI processes complete. |
codespell -q 3 -S *.ts,./libs,./sample-projects -L searchin