Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if using a custom pandoc installation #577

Merged
merged 1 commit into from May 20, 2019

Conversation

kakaroto
Copy link
Contributor

@kakaroto kakaroto commented May 9, 2019

Fixes #563

@gedakc
Copy link
Collaborator

gedakc commented May 19, 2019

Following post HEAVILY edited.

When testing on Kubuntu 16.04 with this PR patch applied to current develop branch, I still experience a crash with a Pandoc custom path. <-- Encountered issue #535 instead.

See issue 563 - steps to reproduce crash.

Following is the console log:

<snip>

Perhaps I made a mistake in testing.

Can you retest?

@gedakc
Copy link
Collaborator

gedakc commented May 19, 2019

Ah, just found that the crash I'm experiencing is due to Issue 535 - pandoc export crashes if project title is empty.

I will update the test steps and re-test.

@gedakc
Copy link
Collaborator

gedakc commented May 19, 2019

After re-testing this PR with the updated steps, Manuskript no longer crashes when using a Pandoc custom path.

See issue 563 - steps to reproduce crash.

Using Ubuntu 16.04 I have confirmed that this PR fixes the crash.

If no concerns are raised then I will plan to merge this PR with the develop branch in the next day or so.

@gedakc gedakc added this to the 0.10.0 milestone May 19, 2019
@gedakc
Copy link
Collaborator

gedakc commented May 20, 2019

'Merging this PR with the develop branch for inclusion in the next release of Manuskript.

@gedakc gedakc merged commit f1baab8 into olivierkes:develop May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when exporting with pandoc as custom path only
2 participants