Fix crash if invalid character is inserted into the text. #578
Conversation
If an invalid character is inserted into the text, such as a "^L" (ASCII 0x0C) when copy-pasting from a google document that has a page break in it, a crash will happen as the character cannot be inserted into XML. This patch removes those invalid characters from the text so the revisions.xml can be saved. Fixes olivierkes#562
|
Question: wouldn't it be better to convert the character to it's correct manuskirpt counterpart? Perhaps it's not a task for this particular action (as it's a bug-fix, it definately shouldn't crash), but perhaps it should honour the line-break in some way? |
|
As far as I could find, there is no line-break counterpart in manuskript. Also, the character remains in the text, it only gets removed from the XML file (revisions) so you'd only lose it if you restore previous revisions. Note also that this is how I got to reproduce this crash, but any other non-xml-acceptable character would cause the same issue unfortunately. |
|
Using the instructions from issue #562 I have confirmed the "crash on save" in kubuntu 16.04. With the patch applied the "crash on save" does not occur. I believe that the patch is a good compromise because we never want Manuskript to crash, and the likelihood that someone needs to restore text containing an invalid XML character, such as Ctrl+L, is slim. I will merge this PR with the develop branch. |
If an invalid character is inserted into the text, such as a "^L" (ASCII 0x0C)
when copy-pasting from a google document that has a page break in it, a crash
will happen as the character cannot be inserted into XML. This patch removes
those invalid characters from the text so the revisions.xml can be saved.
Fixes #562