Fix pandoc export crashes is project title is empty #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While this proposed PR worked on Kubuntu 16.04, the same solution failed on Windows 10. EDIT: |
gedakc
force-pushed
the
i535-fix-pandoc-export-crash-title-empty
branch
from
6af6d85
to
7eebe7e
Compare
|
This PR is available for review and comments. |
kakaroto
reviewed
May 26, 2019
gedakc
force-pushed
the
i535-fix-pandoc-export-crash-title-empty
branch
from
7eebe7e
to
41de36a
Compare
|
This PR has been successfully tested on Kubuntu 16.04, Fedora 29, and Windows 10. With the PR applied there were no export crashes when the project title field was empty. I will rebase and merge this PR with the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the crash mentioned in issue #535.
For test steps see issue 535 - steps to reproduce crash.