Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when setting word Goal on new Text (scene) in Outline pane #609

Merged
merged 1 commit into from
Jul 31, 2019

Commits on Jul 23, 2019

  1. Fix crash when setting word Goal on new Text (scene) in Outline pane

    See issue olivierkes#561.
    
    The problem appears to be a due to a combination of factors, such as:
    
    - Python does not automatically convert an empty/blank variable to the
      integer zero (0)
    - Default goal value is empty/blank for a new Text (scene)
    - Asynchronous events can occur such that the change in the Outline
      pane of a new Text (scene) goal from empty/blank to a value is not
      saved to the data model prior to the update event in the Editor pane
      accessing the model value for the word count progress display.
    
    Steps to Reproduce:
    
    1. Start manuskript and create new project (no template).
    
    2. Select **Outline** pane.
    
    3. Click "Text Plus" icon to create a text (default name "New")
    
    4. Select **Editor** pane.
    
    5. Click on **New** to display empty text.
    
    6. Select **Outline** pane.
    
    7. Double-click the empty area on **New** line under title **Goal**,
      type in "300", and press **Enter**.
    
       Note that manuskript crashes with a segmentation fault.
    
    Work around the crash by using the already existing manuskript
    function toInt() which handles conversion of empty/blank values to
    integer value zero (0).
    gedakc committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    22ec87b View commit details
    Browse the repository at this point in the history