Basic dark theme support (Windows 10) #630
Conversation
Windows 10 has supported a 'dark theme' option for a while, and the fact Manuskript is like looking into a bastion of bright white while using it is bothersome to say the least. Since this is a setting defined as the OS level, I believe this should be something Manuskript automatically adjusts itself to match, thus the lack of a configurable setting on the Manuskript end.
|
I had cleaned up my comments before sending in the PR, but had forgotten to add the changed source file when amending the original commit, so they weren't actually registered. Whoops. Btw, for good measure, have a screenshot of what it looks on my end with the dark theme patch enabled: (ignore the testing data that I used for the other PR; I didn't realize that one was showing!)
(The editor area that by default has a white background has been manually adjusted to have a dark background.) |
|
I performed regression testing on this PR and no adverse issues were discovered with the following:
Further the K Desktop Environment Breeze and Breeze Dark themes continued to work as expected. Manusrkipt on Kubuntu 19.04 with Breeze theme Manuskript on Kubuntu 19.04 with Breeze Dark theme Hence this PR looks good to me. If no concerns are raised then I plan to merge this PR with the develop branch in the next day or so. |
|
I always assumed that KDE-based distros would work out of the box because they use Qt under the hood.. and it seems they do. 馃憤 It is nice to see that the dark theme patch for Windows resembles that Breeze Dark theme for KDE to such a high degree! FYI: This patch has a platform check for Windows, and then checks a registry entry that should only exist on a Windows version that supports the 'dark theme' toggle.. so if we had any sort of regression on any other OS, there would have been some really funky business going on. 馃ぃ Having seen your screenshots, I am all happy with it! |
|
Great work @worstje. I'll bet that this enhancement will make many Windows 10 users happy. We've had many votes for dark theme as can be seen in issue #388. I will merge this PR with develop for inclusion in the next release of Manuskript. Would you update the How to Enable Dark Theme Wiki entry for Windows 10? Thanks, |
|
Done. 馃憤 |
Windows 10 has supported a 'dark theme' option for a while, and the fact
Manuskript is like looking into a bastion of bright white while using it
is bothersome to say the least.
Since this is a setting defined as the OS level, I believe this should
be something Manuskript automatically adjusts itself to match, thus the
lack of a configurable setting on the Manuskript end.
Note that it does not adjust the main editor area since that is already user configurable.
For as far I have been able to check, it works with every builtin theme that is selectable in the Settings screen and produces legible output. (I would not go as far as to call it pretty, simply because most of them aren't pretty to begin with. 馃槈 )
I looked into Linux-land for a little while to not make this a Win10-only commit, but there is no separate 'dark theme' switch on Ubuntu at least. And even then there is the mess between Gnome and Qt themes to worry about, which means dragging in a whole new library of which I have already forgotten the name and compiling against that... suffice to say I'll leave any such challenges to the people who improving the themes-related situation on Linux. 馃槃 )