Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DISABLE_WAYLAND to snapcraft.yaml #637

Merged
merged 1 commit into from Sep 12, 2019

Conversation

gedakc
Copy link
Collaborator

@gedakc gedakc commented Sep 11, 2019

See request at:
#511 (comment)

@jshamg @tomwardill if someone could review/test this PR then that would be much appreciated.

We would like to create a 0.10.0 release soon and I plan to merge this PR prior to the release.

Curtis

@gedakc gedakc added this to the 0.10.0 milestone Sep 11, 2019
@jshamg
Copy link

jshamg commented Sep 12, 2019

@gedakc I would really like to help. I'm not that much into snap. I don't know how to compile that. If you tell me what to do I can test it :) greetings!
Josh

@tomwardill
Copy link
Contributor

I can definitely build and test this on a Ubuntu 19.04 system, but I don't run wayland currently.
I'll see if I can produce a test env for this.
I'll have time today/this evening to have a look.

@tomwardill
Copy link
Contributor

I've built and tested this on a ubuntu 19.04 system, both with and without wayland. Can confirm that manuskript starts and seems to work normally.

@gedakc
Copy link
Collaborator Author

gedakc commented Sep 12, 2019

Thank you @tomwardill for testing this PR. And for making it possible to build snap packages in the first place. :-)

I will merge this PR with the develop branch for inclusion in the upcoming 0.10.0 release of Manuskript.

Question:
Will a new snap package be automatically created when we release 0.10.0, or do you need to manually invoke a build?

@gedakc gedakc merged commit 846c0e9 into olivierkes:develop Sep 12, 2019
@tomwardill
Copy link
Contributor

@gedakc I can't help with the release I'm afraid, the package on the store is owned by @olivierkes, so they are handling the releases.
Looks like it might be hooked up via build.snapcraft.io, so a build may be automatic.

@gedakc gedakc deleted the snap-pkg-disable-wayland branch September 12, 2019 16:11
@gedakc
Copy link
Collaborator Author

gedakc commented Sep 12, 2019

'Hopefully it will be an automatic build. I haven't seen any activity on the project by @olivierkes for quite some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants