Changes to Revisions UI #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This enhancement looks good to me. From my testing on Kubuntu 16.04 the UI changes do indeed prevent setting the "revisions per X" values to zero, and that was the cause of the crash reported in issue #381. If no concerns are raised then I plan to merge this PR with the develop branch in the next day or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #401, #653, #654 for discussion regarding these changes.
Note that this was the prettiest I was able to get the warning for now. I wanted to add some margins to the label but alas, they are a finnicky thing. The only workaround I could find involves adding a whole new parent widget and layout, but I couldn't quite figure out how the auto-sizing works.
Since I don't want to ruin the accessibility for small screens or weird DPIs by hardcoding a fixed widget size, and because this message will hopefully only be there for one version, I figured this solution would be good enough to get the message across.