Fix for Windows 10 Dark Theme on older Qt versions #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QtCore.Qt.GlobalColor does not have any accessors for the predefined colors on PyQt versions before 5.11 despite the object itself existing. It would have been nice if the documentation* had mentioned that object being broken on older versions, but I should have tested with even older versions of PyQt before submitting the original patch. Apparently the most supported way to access these colors is through the Qt namespace itself, but those aren't documented in the slightest. Ugh. My apologies to all those affected. Fixes issue olivierkes#659. *: https://www.riverbankcomputing.com/static/Docs/PyQt5/api/qtcore/qt.html#GlobalColor
|
A win32 PyInstaller package with PR 660 applied is ready for testing. https://sourceforge.net/projects/manuskript/files/manuskript/testing-only/ |
|
@gedakc It has been properly fixed with that test build. I tested both the original release package (=crash as expected) and the new one with the fix applied (=all good). |
|
Thank you @worstje for confirming that the new package works as expected and prevents the crash. I will merge this PR with the develop branch. Further I plan to rename the test package file from: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QtCore.Qt.GlobalColor does not have any accessors for the predefined
colors on PyQt versions before 5.11 despite the object itself existing.
It would have been nice if the documentation* had mentioned that object
being broken on older versions, but I should have tested with even older
versions of PyQt before submitting the original patch.
Apparently the most supported way to access these colors is through the
Qt namespace itself, but those aren't documented in the slightest. Ugh.
My apologies to all those affected. Fixes issue #659.
*: https://www.riverbankcomputing.com/static/Docs/PyQt5/api/qtcore/qt.html#GlobalColor
@gedakc Can you create a new Windows build with this fix implemented and put it on the website? (I cannot currently test it on Qt 5.5 but since it reproduced on 5.8 I assume this bug is fixed.)
I will look into setting up a proper test environment for Qt5.5 on my end in the future so I won't have to depend on you to test it on older PyQt versions anymore. I should have caught this before I submitted the PR. 馃槩